Sometimes it's helpful (depending on the size of the test) to catch and wrap an exception in order to describe the context in which the exception was thrown—what the test was trying to do at the time. That can make life a little easier for whoever has to diagnose a failure.There are potentially better ways to give context, such as extracting the try/catch block into an expressively-named method, so that the method name in the stack trace describes the context. If I were writing these classes from scratch, I'd use the nicely-named method technique. But with existing tests… I dunno. I don't have a clear sense of how far to impose my preferences onto existing tests.
[ Full content available at: https://github.com/apache/geode/pull/2343 ] This message was relayed via gitbox.apache.org for [email protected]
