@gianm agree that columns can be filterable without bitmap indexes. however,
independently,
only use of `Filter.FILTERABLE_TYPE` is in
`ColumnSelectorBitmapIndexSelector.columnSupportsFiltering(column)` which looks
like
```
private static boolean columnSupportsFiltering(Column column)
{
ValueType columnType = column.getCapabilities().getType();
return Filters.FILTERABLE_TYPES.contains(columnType);
}
```
and at its call sites, it is used to check whether to work with an empty bitmap
or get one from column. it appears, everything would stay exactly same even if
I changed above implementation to...
```
private static boolean columnSupportsFiltering(Column column)
{
return column.getCapabilities().hasBitmapIndexes();
}
```
with above done, there is no more any usage of `Filter.FILTERABLE_TYPE` .
I must be missing something.
[ Full content available at:
https://github.com/apache/incubator-druid/pull/6223 ]
This message was relayed via gitbox.apache.org for [email protected]
