- `Math.abs(random.nextInt())` doesn't guarantee positivity - `random.nextInt() % x` - `new Random()` should never be used, `ThreadLocalRandom.current()` or `SplittableRandom` instead.
I also replaced most `new Random(SOME_CONSTANT_SEED)` in benchmarks with `ThreadLocalRandom.current()` because benchmarks shouldn't generally be always identical, randomness between the runs could make results statistically more reliable. [ Full content available at: https://github.com/apache/incubator-druid/pull/6226 ] This message was relayed via gitbox.apache.org for [email protected]
