I take apart it on two types - values what default by None and we raise the 
error as with sql. So priority will be on arg keyword, and only if it not exist 
- check api_resource and get key from it. Or you think need to raise error 
anyway if keys are duplicated? 

Or maybe just warning.

2-nd thing is keys what have default values like useLegacySql or priority. 
Because they are is not None by default we can not check what they were set by 
a user or not. But, I really don't see necessary for those default settings, 
because they default in google API and as I understand we do not need to 
provide them. But more I look on this config in the run_query, more want to 
change globally logic, or refactor part with configuration generating or forget 
idea with api_ var and just add useQueryCache param )) too many ifs...

[ Full content available at: 
https://github.com/apache/incubator-airflow/pull/3733 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to