> I don't think we want to say "null is illegal" in this case; I think it is > legal for backwards compatibility.
I don't see any backwards compatibility in place here - that method would be introduced in `2.1.0` and this PR too. I do agree that it is better for `validateExtensions()` to do one thing only and that is validate the extensions without returning anything. The question of this comment thread is: where should the potential `null` value be handled? My thoughts, in order of preference, are: 1. `SaslExtensionsCallback` - ensure it doesn't return null 2. `OAuthBearerInitialClientResponse`'s constructor 3. `validateExtensions()` method [ Full content available at: https://github.com/apache/kafka/pull/5552 ] This message was relayed via gitbox.apache.org for [email protected]
