Sounds good, thanks for checking! > On Aug 23, 2018, at 10:39 PM, Nabarun Nag <[email protected]> wrote: > > @nabarunnag commented on this pull request. > > In > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java: > > > @@ -207,8 +207,12 @@ private void > > destroyKeyFromBucketQueue(AbstractBucketRegionQueue brq, Object key > } > // add the key to failedBatchRemovalMessageQueue. > // This is to handle the last scenario in #49196 > - brq.addToFailedBatchRemovalMessageKeys(key); > - > + // But if GII is already completed and FailedBatchRemovalMessageKeys > + // are already cleared then no keys should be added to it as they will > + // never be cleared and increase the memory footprint. > + if (!brq.isFailedBatchRemovalMessageKeysClearedFlag()) { > @metatype > Going through the documentation about auto-reconnect, when a member > disconnects from a distributed system, it shuts down and restarts in a > "connecting state". > > When it restarts, all the BucketRegionQueues are created again hence setting > the flag to false, does the GII and then cleans out any failed batch removal > messages that could have arrived during the GII phase and then sets the > failedBatchRemovalMessageKeysClearedFlag to true. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread.
[ Full content available at: https://github.com/apache/geode/pull/2375 ] This message was relayed via gitbox.apache.org for [email protected]
