This test is only rewriting sync calls to use async calls. Although `markLedgerUnderreplicatedAsync` is an async method, it is still used in sync ways across the places at Auditor. That says this PR doesn't change any existing logic how Auditor uses `markLedgerUnderreplicated`. from functionality wises, we don't need separate test cases.
Agreed that we need to have better coverage and since `makrLedgerUnderreplicatedAsync` is now at the interface, people might be using it in a different place. Those should be done in a separate PR rather than this PR. so I created a separate issue for tracking test coverage: https://github.com/apache/bookkeeper/issues/1626, not trying to combine changes with different purposes into one PR. [ Full content available at: https://github.com/apache/bookkeeper/pull/1619 ] This message was relayed via gitbox.apache.org for [email protected]
