@tedyu, I agree the javadoc is not very clear. I'm not sure we should press ahead until we investigate the semantics further.
Taking another look at the existing code, it looks like we would not actually skip closing the `FileChannel`. I haven't checked up the call chain. What is the ultimate result of the `IOException`? Does it kill the thread, or is it caught and handled somewhere? All in all, it seems safer to throw an exception if we're not sure whether the lock was released or not. [ Full content available at: https://github.com/apache/kafka/pull/5574 ] This message was relayed via gitbox.apache.org for [email protected]
