If `onControllerFailover()` throws `ControllerMovedException` after controller 
has registered itself as controller, it seems possible that some events may 
have already been inserted into the controller event queue. Should we propagate 
the `ControllerMovedException` to `ControllerEventThread` in order to clear the 
controller event queue?

Also, I think in most places we will just name the exception varaible as `e` 
and throwable variable as `t`. Naming them e1, e2, and specifically naming a 
throwalble as `e2`, seems unusual. I know this style is used in the existing 
controller code. I am wondering if we can change this.

[ Full content available at: https://github.com/apache/kafka/pull/5101 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to