I have the following comments:

*lwIP static routing addon:* As I mentioned, this library was rejected when I 
attempted to merge it into mynewt-core earlier.  The suggestion was write our 
own add on.  

*tu_time_advance()*: This commit contains a hack to make things work (`extern 
struct os_callout_list g_callout_list;` in a source file).  I would want to do 
this properly before merging it.

Aside from the above, it looks good to me.  Do you want to split this PR up so 
that parts can be merged?

[ Full content available at: https://github.com/apache/mynewt-core/pull/1353 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to