Thanks for the patch, @flavray. The patch looks reasonable to me.

I think another way to implement this fix could be to enforce the condition 
that we do not exceed the configured maximum metadata size when appending to 
the log in `GroupMetadataManager#storeGroup`. It looks like we already have 
some validation in `GroupMetadataManager#storeOffsets` so may be we are missing 
this in `storeGroup`? This would mean that users will see this error when 
metadata exceeds the configured limit though.

cc @hachikuji as he should have more context about this.

[ Full content available at: https://github.com/apache/kafka/pull/5500 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to