i see that BookKeeperClusterTestSuite has static method with same 
signature/annotation. In java there is nothing like static method overriding, 
but this is junit quirk - "in JUnit BeforeClass methods should be named 
differently, otherwise will result in only the subclass method being run 
because the parent will be shadowed." 

For a regular user it is little confusing to see method with same name and 
@BeforeClass annotation, probably we should remove @BeforeClass annotation for 
setUpCluster method in BookKeeperClusterTestSuite or may be pass numBookies as 
argument to the constructor just like in BookKeeperClusterTestCase.

[ Full content available at: https://github.com/apache/bookkeeper/pull/1629 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to