@oleg-zinovev besides comment in the PR I suggest a couple more things:
1. File a Jira for failed tests (indicating what and why fails - basically copy 
info from the PR description + indicate affected JDKs).
2. As I understand the purpose of this PR is allow build on JDK 9 and 10. Maybe 
it's better to rename commit message to highlight this. Description of the 
changes (which was really useful during the review, thanks for that!) can be 
included the commit message as well. 

[ Full content available at: https://github.com/apache/drill/pull/1446 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to