### Platforms affected
ios
### What does this PR do?
- Remove xcconfig build flag for device and emulator.
- Remove custom argument override for xcconfig.
- Updated build test spec with removal of xcconfig with cleanup.
Since Cordova projects are using `xcworkspace` and the
`content.xcworkspacedata` file declares our projects `xcodeproj`, the
`xcconfig` file paths are declared in the `pbxproj`.
*contents.xcworkspacedata*
```
<FileRef location = "group:HelloCordova.xcodeproj"></FileRef>
```
Once a Pod project is added to the application, for example
`cordova-plugin-firebase-messaging`, the `contents.xcworkspacedata` file is
updated to reflect the Pod project.
```
<FileRef location = "group:HelloCordova.xcodeproj"></FileRef>
<FileRef location = "group:Pods/Pods.xcodeproj"></FileRef>
```
If the xcconfig flag was set, in this scenario, pathing issues are introduced.
For example header files will not be found and can not load. The xcconfig flag
is applied to the entire workspace and will affect also the pod project’s
xcconfig files.
*Example*
* In our application, the `SRCROOT` varaible is declared as `platforms/ios`.
* With the current implmetation (xcconfig flag deifned) the `SRCROOT` variable
will be declared as `platforms/ios/Pods` for pod project.
In this case, in regards to the last item, the `PODS_ROOT = ${SRCROOT}/Pods` in
`Pods-HelloCordova.debug.xcconfig` will be defined as `platforms/ios/Pods/Pods`
which is incorrect.
```
$ cordova create podtest com.foobar.podtest
$ cd podtest
$ cordova platform add [email protected]
$ cordova plugin add cordova-plugin-firebase-messaging
$ cordova prepare ios
$ cordova compile ios
```
You will noticed incorrect paths for example:
`/cordova/podtest/platforms/ios/Pods/Pods/Headers/FirebaseCore -`
By removing the flag, the `SRCROOT` will not be affected for the pods project
so that when `Pods-HelloCordova.debug.xcconfig` declares `PODS_ROOT`, the path
will then be correct `platforms/ios/Pods`.
### What testing has been done on this change?
WIP
- [] `npm test` locally
- [] `cordova build ios`
- [] `cordova run ios`
- [] `cordova prepare ios`
- [] `cordova compile ios`
[ Full content available at: https://github.com/apache/cordova-ios/pull/398 ]
This message was relayed via gitbox.apache.org for [email protected]
