@graceguo-supercat great change! A couple of aesthetic comments: - there looks like there's double padding between the buttons, could we cut it in half? - could we update the messaging to the following (minor tweaks, I don't think the warning/note keywords are needed since we're using a modal):
""" **Delete dashboard tab?** Deleting a tab will remove all content within it. You may still reverse this action with the **undo** button (...+ z) until you save your changes. """ [ Full content available at: https://github.com/apache/incubator-superset/pull/5771 ] This message was relayed via gitbox.apache.org for [email protected]
