> However, this needs an integration test, that starts a 3.5 server, creates > contains, and uses create2, then rolls back to ensure we can read the log.
Sure. I tested manually so far. I have seen some `createContainer` txns (`/stream/controller`) for dlog. It might be easy to add integration test that starts ZK from pulsar-2.1.0 docker image, writes some stuff and then upgrade to latest image with zk-3.4.x. Tricky part might be the zk-client dependency, but let's see. > Another alternative approach, though with more manual intervention, would be > to make the user snapshot the zookeeper instance before upgrade. Could be > ropey. Yes, since we're not actually depending on any of these new txn types, I wanted to have the smoothest downgrade path. > What about users which are sharing the zk instance for something else and are > using the container stuff? I wouldn't worry too much about this case of someone's using Pulsar bundled ZK and expecting it to be 3.5.x for some other applications. [ Full content available at: https://github.com/apache/incubator-pulsar/pull/2473 ] This message was relayed via gitbox.apache.org for [email protected]
