This was previously opened as PR but prematurely closed: https://github.com/apache/cloudstack/pull/1931 https://github.com/apache/cloudstack/pull/1932
Storage pool checker is not being called on resize and migrate volume. This may lead to allocated percentage of storage above 100%. Setup: 1 VMware cluster with 2 Hosts. Executed Steps: Applied the following global settings: storage.overprovisioning.factor = 1 pool.storage.allocated.capacity.disablethreshold = 1 pool.storage.capacity.disablethreshold = 1 Restarted management server Executed Resize and migrate pool and Observed that Storage pool checker is not performed on resizeVolume and migrateVolume. Result: Root cause analysis shows storage pool checker is not called when doing migration and resizing. Signed-off-by: Rohit Yadav <[email protected]> ## Description <!--- Describe your changes in detail --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. [ Full content available at: https://github.com/apache/cloudstack/pull/2829 ] This message was relayed via gitbox.apache.org for [email protected]
