When I was reviewing this part last time, I was only concerned that both `getBufferBuilder(targetChannel);` and `tryFinishCurrentBufferBuilder(targetChannel);` are accessing `bufferBuilders[targetChannel]` twice. However performance penalty (if any) shouldn't be important and I liked the new code more :)
Regarding `finishCurrentBufferBuilder`. `tryFinishCurrentBufferBuilder` is currently used also in one more place (`broadcastEvent()`), so we would need to add there an `if` check preceding a call `finishCurrentBufferBuilder`. Either way, I don't mind, if you prefer one way over another feel free to change :) [ Full content available at: https://github.com/apache/flink/pull/6417 ] This message was relayed via gitbox.apache.org for [email protected]
