## Description ##
* Fix for the issue - https://github.com/apache/incubator-mxnet/issues/11849 
* Currently, Gluon symbol block cannot import any symbol with type other than 
fp32. All the parameters are created as FP32 leading to failure in importing 
the params when it is of type fp16, fp64 etc,
* In this PR, we infer the type of the symbol being imported and create the 
Symbol Block Parameters with that inferred type.

Created this PR for getting the early feedback. I am working on adding test 
cases for this and will update the PR soon.

@szha @hetong007 @apeforest - Can you please take a look at this?
@Roshrini - I think this is important fix to be picked for 1.3. @szha ?

## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a 
new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new 
build option with NCCL)
- [ ] Code is well-documented: 
- For user-facing API changes, API doc string has been updated. 
- For new C++ functions in header files, their functionalities and arguments 
are documented. 
- For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
- Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [X] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change

### Changes ###
* In this PR, we infer the type of the symbol being imported and create the 
Symbol Block Parameters with that inferred type.
* If we cannot infer the type, we go by usual route using default dtype (fp32) 
for creating the parameters.


[ Full content available at: 
https://github.com/apache/incubator-mxnet/pull/12412 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to