That's a first pass of commentary. One additional note - I don't like the fixed
buffer size approach to reading the configuration files. I think it's better to
do something like `ts::file::load` in the IP Allow PR, which loads the entire
file in to a `std::string` at the beginning. Parsing is much easier then and
has no arbitrary limits. It's even easier if you use `TextView`, so that
getting the first line is something like
```
std::string content = ts::file::load(path);
ts::TextView line =
ts::TextView{content}.split_prefix_at('\n').trim_if(&isspace);
// line has the first line with white space removed from both ends, so "
#include" is valid
```
[ Full content available at: https://github.com/apache/trafficserver/pull/4099 ]
This message was relayed via gitbox.apache.org for [email protected]
