when I first read this it wasn't clear to me what `visitChart` meant. While it 
seems possibly useful to have a method that could handle 3 different types of 
input, since they are all mutually exclusive could we instead create 3 methods 
with more descriptive names which each expect one type of input?

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5693 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to