It seemed ok to use some id / class selectors that are less likely to change. 
But when I google around for blogs discussing making UI tests resilient to 
change, this pattern comes up often.

This was a particular case where there was no identifier on the tag that was 
unique to it being a metric control (vs other type of control), so I needed to 
add some kind of id or identifier here, seemed good to be clear that it's just 
used for testing (so we know not to remove / change it). That's the reason I 
like using `data_test`, but I can change it if you feel strongly.

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5693 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to