one comment here is that I may have broken this flag when moving to webpack 4 which introduced the concept of `mode=production/development`. I thought that also set a `NODE_ENV` (because webpack 4 was supposed to be all about smart defaults) but it seems like that [might not be true](https://github.com/webpack/webpack/issues/6460).
So I think we either need to - reference the mode variable (ie `argv.mode === 'production'`) - explicitly define the `NODE_ENV` in our npm webpack scripts (`NODE_ENV=production webpack ...`) I can fix this in a separate PR as well if you prefer because it might have implications for the other logic in this file that relies on `isDevMode` (which I think is always true right now) [ Full content available at: https://github.com/apache/incubator-superset/pull/5786 ] This message was relayed via gitbox.apache.org for [email protected]
