Have we verified that it's safe to do the rename after the checkpoint calls? 
Also, it seems like the following code in `replaceCurrentWithFutureLog` does 
the `rename` before `close` and needs to be updated too.

```scala
        sourceLog.renameDir(Log.logDeleteDirName(topicPartition))
        // Now that replica in source log directory has been successfully 
renamed for deletion.
        // Close the log, update checkpoint files, and enqueue this log to be 
deleted.
        sourceLog.close()
        checkpointLogRecoveryOffsetsInDir(sourceLog.dir.getParentFile)
        checkpointLogStartOffsetsInDir(sourceLog.dir.getParentFile)
```

[ Full content available at: https://github.com/apache/kafka/pull/5603 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to