So it looks like there is no clearly better choice. Typically I feel it is probably better to refactor code if the new solution is better. The reason is mainly to reduce the code conflict with patches from other contributors and also to reduce the need for other contributors to learn the new pattern.
Since @ijuma seems OK with the new style, we can do the refactor as is. [ Full content available at: https://github.com/apache/kafka/pull/5564 ] This message was relayed via gitbox.apache.org for [email protected]
