**after fighting with this for a whole day without changing the core logic I'm convinced it's just about unmapping the right file before doing a `atomicMoveWithFallback`, on Windows**. Every time I fix an exception, I get a new class (such as `FileRecords.java`) going at it, and using `renameTo` or whatever. At each fix the list seems to get bigger, all trying to move or delete files :)
I honestly don't like fixing many files or function if where they fail is at the same `atomicMoveWithFallback`. I have no idea how to properly `unmap` / `lock` there but if someone knows I'm happy to test. Just needs the right `if` statement for windows and voila. The only line I'm pretty sure should be added is: https://github.com/apache/kafka/pull/5604/files#diff-a9e5d1bd0d445d2ed2efff53fb74f2b1R833 Unfortunately that's how far my "deep internals of Kafka" knowledge goes, but I'm sure @ijuma or @lindong28 can probably make sense of me way more than I do and fix this at the right spot Hope that helped [ Full content available at: https://github.com/apache/kafka/pull/5604 ] This message was relayed via gitbox.apache.org for [email protected]
