I find your analysis to be very plausible after a quick glance over the code. Given that there's already more sync stuff happening than async in this particular module (all the `shelljs` stuff is sync too), I would not object a fix that simply uses `fs.readFileSync`. An easy fix might be a good start anyway, so we can verify the fix in "production". But if you'd like to do a nice async version of this, I think nobody will be stopping you. Any PRs welcome!
I particularly like that someone already found the error but chose to ignore it :sweat_smile: https://github.com/apache/cordova-coho/blob/5d710a3bb1838d1e822ee0ed4f830374c6c4b180/src/versionutil.js#L92-L93 [ Full content available at: https://github.com/apache/cordova-coho/issues/195 ] This message was relayed via gitbox.apache.org for [email protected]
