I think this PR is fine to merge. To me it seems that mostly this is just moving functionality about ... the OidAdapterMap and PojoAdapterMap are still present, but relocated to ObjectAdapterContext.
The most significant change is that ObjectAdapter#rootOid is now final, and so the replacePojo stuff has gone, instead the ObjectAdapter is copied if the rootOid changes. This seems ok to me - or at least will be once we get to the stage where ObjectAdapters are instantiated as required and then discarded immediately afterwards. The ObjectAdapterProvider#specificationForViewModel(...) - which returns an ObjectAdapter - looks a bit odd; I've created a separate comment for that. I suspect this is work in progress so happy to see how it plays out, but this code does look weird at the moment. [ Full content available at: https://github.com/apache/isis/pull/120 ] This message was relayed via gitbox.apache.org for [email protected]
