this `lgtm`, I like the `WithLegend` component, it seems like it should be 
pretty flexible ( ;) ) with the various render props, too.

My only comment would be on aesthetics for the `bottom` orientation: should we 
match the `flex-end` `justify-content` alignment of the `top` orientation for 
consistency instead of `center`? could get @elibrumbaugh 's thoughts on this as 
well, or I'm happy merging this to land it and making tweaks later.

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5758 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to