@bbejeck I think I've addressed all your concerns.

About the system tests / performance concerns: yes, I plan to follow up with 
that once the features themselves are merged:

1. this PR (API only)
2. independent names for suppression nodes
3. in-memory buffering (not resilient to node shutdown/crash; spill-to-disk not 
implemented)
4. resilient buffering (wrap the buffer in a changelog)
5. spill-to-disk buffering
6. performance testing & optimization

This was the set of smallest diffs I could think of that made sense to review. 
Please let me know if some other subdivision makes sense.

/cc @guozhangwang 

[ Full content available at: https://github.com/apache/kafka/pull/5567 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to