@tmysik In the below case, unit tests fail if we implement the new syntax. We cannot implement both syntaxes at the same time. However, a user should be able to choose another marker instead. In this case, e.g. choose `HEREDOCMARKER` instead of `ENDOFHEREDOC`
https://github.com/apache/incubator-netbeans/blob/6a382b93ebc5a99ee99306b8c758126aba9de59c/php/php.editor/test/unit/data/testfiles/parser/heredoc_009.php#L8-L24 My idea: Just don't provide support for the above case(the old syntax) because I think that that case is almost never used and we can use another marker instead. That way, we need not create a new lexer for PHP 7.3, maybe. What do you think? Thanks. [ Full content available at: https://github.com/apache/incubator-netbeans/pull/840 ] This message was relayed via gitbox.apache.org for [email protected]
