I like that you put all the diag setup work in the DiagOpProcess function, but now that leaves DiagOpForward as a function that doesnt actually do anything. It seems like an unnecessary additional function call to call DiagOpProcess. What do you think about inlining DiagOpProcess inside of DiagOpForward? Or is there some benefit to doing it this way that im missing?
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12430 ] This message was relayed via gitbox.apache.org for [email protected]
