I don't like this change. It is confusing to have something called "result" but 
you end up returning something else. I'd go back to the old code or change the 
code to something like this:
int lengthFromCode = ubyteToInt(code);
if (lengthFromCode <= MAX_BYTE_ARRAY_LEN) {
  return lengthFromCode;
}
if (code == SHORT_ARRAY_LEN) {
  return in.readUnsignedShort();
...

[ Full content available at: https://github.com/apache/geode/pull/2434 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to