CI is green again. Can someone review this again?
Summary:
* Use system zlib by default
* Changed.
* System zlib is searched by `pkg-config` or from the default system path
* Use the specified zlib when `ZLIB_HOME` is specified
* Not changed.
* If `ZLIB_HOME` is specified, system zlib isn't searched by `pkg-config`
* Not changed.
* Use vendored zlib as fallback (no `ZLIB_HOME` and no system zlib)
* Changed. Vendored zlib was the default.
* Use system zlib as shared library
* Changed. Zlib was always used as static library.
* Use `ZLIB_HOME` zlib as shared library
* Changed. Zlib was always used as static library.
* Use vendored zlib as static library
* Not changed.
* Bundle zlib into wheels for Windows.
* Changed.
* Zlib isn't bundled into wheels for manylinux1 and macosx because we can
assume zlib exists on these platforms.
* See also:
*
https://mail.python.org/mm3/archives/list/[email protected]/thread/ZZG6GL3XTBLBJXSITYHEXMFKN43EREB7/
*
https://mail.python.org/mm3/archives/list/[email protected]/message/HLX65TU6U7N3JTUU4YRLBQNSFKZTG52X/
* Build directory is always removed on AppVeyor.
* Changed.
* Because CMake's cache reports wrong result.
* Use zlib in the build target Python directory instead of
`ARROW_BUILD_TOOLCHAIN` on Travis CI.
* Changed.
* Because linking with zlib in `ARROW_BUILD_TOOLCHAIN` causes wrong
`libpython.dylib` load on macOS. See comment in `ci/travis_script_python.sh`
for details.
* `after_failure` change in `.travis.yml` is a by-product of debugging crash
on macOS.
* Should I separate this change to another pull request?
* `ZLIB_LIBS` has been removed.
* Because it's not a good name and we don't use anywhere.
* It doesn't contain library paths. It contains directories that includes
library.
[ Full content available at: https://github.com/apache/arrow/pull/2483 ]
This message was relayed via gitbox.apache.org for [email protected]
