The way this class associates components to mpacks (and services in 
`copyAndEnrichMpackInstances`) is a bit redundant, since it's already performed 
by 
[`StackComponentResolver`](https://github.com/apache/ambari/blob/branch-feature-AMBARI-14714/ambari-server/src/main/java/org/apache/ambari/server/topology/StackComponentResolver.java)
 and the result is stored in 
[`ResolvedComponent`](https://github.com/apache/ambari/blob/branch-feature-AMBARI-14714/ambari-server/src/main/java/org/apache/ambari/server/topology/ResolvedComponent.java)
 instances.  If some information is missing, I think it should be added there 
to avoid duplicated, and potentially different, implementations.

[ Full content available at: https://github.com/apache/ambari/pull/2259 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to