hmm I guess my method name is misleading. It's not that the suppression is configured like "emit immediately" (there is no such config option, but maybe there should be).
Rather, it's an internal utility method to indicate whether the buffer config allows us to just emit events that are on-time or late, rather than buffering them. Regardless, we still need to buffer future events if there is room to buffer them. This logic is just a little murky right now because there isn't a buffer yet. So this logic is an attempt to emit any event that we can determine right away is legal to emit, since any buffering operation is actually an exception in this PR. I guess I could have made it simpler by just unilaterally throwing an exception for any record here, but I thought it would be nice to have some non-exceptional paths to have tests for. Even though the implementation details will change when we add the buffer, any tests that currently check for events getting immediately emitted should continue to pass on the buffer-based implementation. [ Full content available at: https://github.com/apache/kafka/pull/5567 ] This message was relayed via gitbox.apache.org for [email protected]
