quoting your comment: 

```
It seem we rely on computeLatency() above to advance now -- it seems 
"dangerous" to rely on a "side effect" for this. Should we advance time 
explicitly here? Or at least put a check if now < lastPollMs || now > 
timeSinceLastPoll ?
```

The above change is for addressing this comment. Again I'd admit it is not 
ideal to rely on the side effect of `computeLatency()` to advance `now` but at 
the same time I want to avoid calling system time necessarily. If you feel 
strong about it, I can just go ahead and explicitly advance `now`, does it 
sound better to you?

[ Full content available at: https://github.com/apache/kafka/pull/5428 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to