@azai91 Thanks for your efforts in refactoring this. Since the main purpose of 
this PR is refactoring, I hope we can do it in the most elegant way. If we are 
making this file a public header, I would extract the implementation class Impl 
to another internal header file so that we do not expose the internal  
implementation details. By doing that, we can have put the implementation 
details for both CPU and GPU there. Please let me know your thoughts.

[ Full content available at: 
https://github.com/apache/incubator-mxnet/pull/12374 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to