In general if we want to have a statement that says the event is completed. The
original logging `Unsubscribed all topics or patterns and assigned partitions`
meets this requirement. It is a bit weird to log the event that is happening
without a followup log that says the event is completed.
I agree that the original statement is not accurate by printing
`Unsubscribed...` before doing it. Given that `unsubscribe()` is a simple and
fast method, there is probably no need for additional INFO level logging to
specify whether it is happening. How about we just move the existing INFO log
to the end of the try{...} code block without changing it?
[ Full content available at: https://github.com/apache/kafka/pull/5289 ]
This message was relayed via gitbox.apache.org for [email protected]
