Sounds OK to me, to not do the null check here, since we don't expose the Fetcher class to the user directly. In general, it would be a good practice to check for nulls instead of throwing NPE's at run time for any public apis. In fact, we can use Optional<> feature of Java 8 for doing this. Will update the patch.
[ Full content available at: https://github.com/apache/kafka/pull/5289 ] This message was relayed via gitbox.apache.org for [email protected]
