Thanks for your feedback @brodybits !

> I think it would be good to get the Cordova tooling API documented. Should 
> this be raised as a separate task?

Yes, the tooling libs definitely need better documentation. Prefereable in 
their respective README.
I already added that point to our release planning document, so I think we are 
fine for now.

> If we change the public cordovaCreate function API on cordova-create I would 
> favor allowing the caller to inject the fetch function for smoother mocking. 
> (No need for cordova-lib to export this option, I think.)

I'm not too fond of polluting the public interface for testing only. Jasmine 
spies and `rewire` work pretty well for me, given the test subject has a 
reasonable structure.

If we need DI for real-world use cases, I'm open to it. I would probably move 
it to a separate issue though, as it is an additional feature.

[ Full content available at: https://github.com/apache/cordova-create/issues/21 
]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to