This looks dangerous. At the very least you should get rid of the comment that says "No need to close advisor" since super.distributedRegionCleanup does that. I'm not sure, but I think if you do the super call then you do not need to call removeMembershipListener first. I think the impl in super may take care of that. In that case no need to override on BucketRegion. But I'm concerned that this make cleanup some shared resource that other buckets still needs.
[ Full content available at: https://github.com/apache/geode/pull/2450 ] This message was relayed via gitbox.apache.org for [email protected]
