<!--- Provide a concise summary of your changes in the Title --> ## Description <!--- Provide a detailed description of your changes. --> <!--- Include details of what problem you are solving and how your changes are tested. --> The bugs are not critical, but could hit at some point in edge cases: * When the invoker sends a Ping message and never changes its state to Healthy after that, its name contains only the id without unique and displayed names * `instanceToRef` Map contains the mapping from InstanceId to Actor ref. This accumulates stale data if some invokers get restarted and register under new ids.
I fixed the issues by: * store the full name after registering a new invoker into internal bookkeeping * replaced the mapping in `instanceToRef` to use Int instead of InstanceId. The unit tests coving those change are in place as well. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. [ Full content available at: https://github.com/apache/incubator-openwhisk/pull/4017 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org
