I don't think we do. The idea is to have `logBeingCleaned` (previously `currentLog`) be populated if an exception is raised. That way `cleanOrSleep()` knows which was the faulty log. I think it's clearer to make the variable `None` in the same method it is assigned.
After this comment, I saw that if `cleanerManager#grabFielthiestCompactedLog()` raises an exception, we'll re-raise it as an `IllegalStateException`. Not sure how favorable that is, since that would kill the thread. There still exist code paths that can kill the thread outright (via the re-raising of an exception), but I'm not sure how else to handle such scenarios. Maybe this is okay [ Full content available at: https://github.com/apache/kafka/pull/5439 ] This message was relayed via gitbox.apache.org for [email protected]
