> have completely different window specs

This makes sense -- however, if no suppress operation is defined, this would 
not be detected -- and if we put a check somewhere else, suppress does not need 
to check it either. Does it? Additionally, even if suppress does this check, I 
would exclude the grace period from the check.

> We set suppress's suppression time equal to the grace period of the parent.

>From my understanding, this method should checks that the grace period is 
>larger than the window-size of the upstream KTable -- we don't need to set the 
>grace-period, but just take whatever the users specified for it. There is no 
>comparison of parent grace period and suppress grace period? And there is no 
>need? Or do I miss something?

[ Full content available at: https://github.com/apache/kafka/pull/5567 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to