do you think we should use `React.Fragment`s here? I'm not sure of the 
advantages of them vs arrays (maybe `<>...</>` syntax is supported with our 
build config?)

Did you check the usage as a `MenuItem`? I was wondering if the parent of a 
`MenuItem` (prob a `<ul />`) would care if it had a modal / non-`MenuItem` 
(prob an `<li />`) child . This might not be a problem if the modal renders 
into a portal (not the parent dom container) since it wouldn't create an 
invalid DOM structure. 


[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5865 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to