> @mistercrunch @michellethomas thanks for the reviews! I addressed all > comments. > > For Max's more in depth comments: > > * enabled adhoc metrics on the `metric` controller. Required adding some > additional case statements in the MetricsControl component where I assume > `value` will be an array. Also required some small style updates. > * for making it more clear that the tokens are editable, I had the > AdhocMetricEditPopover appear by default when a new metric is created. I also > updated the default text in the select component. > > I also added another feature that HIDES any auto generated metric that is > just an aggregate + column. > > Please take another look when you have the chance!
Hey, Adhoc metric is good but in some cases, it's a problem. In tableview, if you define an adhoc metric, it has no format as similar as auto general metric. Please don not hide auto general metric anymore! Thank [ Full content available at: https://github.com/apache/incubator-superset/pull/4663 ] This message was relayed via gitbox.apache.org for [email protected]
