I am going to rebase, because an `ink_release_assert` triggered in one of my 
local tests that was likely due to a bug that has been fixed on master branch 
after the commit on which I have based:

```
(gdb) p history
$7 = {history = {{location = {file = 0x826d62 "HttpSM.cc",
        func = 0x829cc0 <HttpSM::state_read_client_request_header(int, 
void*)::__FUNCTION__> "state_read_client_request_header",
        line = 603}, event = 100, reentrancy = 2}, {location = {file = 0x826d62 
"HttpSM.cc",
        func = 0x82a8a8 <HttpSM::set_next_state()::__FUNCTION__> 
"set_next_state", line = 7274}, event = 34463, reentrancy = 2}, {
      location = {file = 0x826d62 "HttpSM.cc", func = 0x82a8a8 
<HttpSM::set_next_state()::__FUNCTION__> "set_next_state", line = 7320},
      event = 34463, reentrancy = 2}, {location = {file = 0x826d62 "HttpSM.cc",
        func = 0x829eb0 <HttpSM::state_http_server_open(int, 
void*)::__FUNCTION__> "state_http_server_open", line = 1731}, event = 200,
      reentrancy = 3}, {location = {file = 0x826d62 "HttpSM.cc",
        func = 0x829d10 <HttpSM::state_watch_for_client_abort(int, 
void*)::__FUNCTION__> "state_watch_for_client_abort", line = 847},
      event = 104, reentrancy = 1}, {location = {file = 0x826d62 "HttpSM.cc",
        func = 0x829eb0 <HttpSM::state_http_server_open(int, 
void*)::__FUNCTION__> "state_http_server_open", line = 1731}, event = 101,
      reentrancy = 1}, {location = {file = 0x826d62 "HttpSM.cc",
        func = 0x829f20 <HttpSM::state_send_server_request_header(int, 
void*)::__FUNCTION__> "state_send_server_request_header",
        line = 2003}, event = 103, reentrancy = 1}, {location = {file = 
0x826d62 "HttpSM.cc",
        func = 0x829ee0 <HttpSM::state_read_server_response_header(int, 
void*)::__FUNCTION__> "state_read_server_response_header",
        line = 1845}, event = 100, reentrancy = 1}, {location = {file = 
0x826d62 "HttpSM.cc",
        func = 0x82a8a8 <HttpSM::set_next_state()::__FUNCTION__> 
"set_next_state", line = 7274}, event = 34463, reentrancy = 1}, {
      location = {file = 0x826d62 "HttpSM.cc",
        func = 0x829fb0 <HttpSM::state_hostdb_lookup(int, void*)::__FUNCTION__> 
"state_hostdb_lookup", line = 2235}, event = 500,
      reentrancy = 1}, {location = {file = 0x0, func = 0x0, line = 0}, event = 
0, reentrancy = 0} <repeats 55 times>}, history_pos = 10}
```

This shows a HostDB lookup event happening after we have already received a 
response from origin. This shouldn't happen, and it does not seem to be related 
to this PR's changes.

EDIT to add: Looks like we need to rebase anyway because we have changed the 
source directory structure last night.

[ Full content available at: https://github.com/apache/trafficserver/pull/4145 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to