It doesn't need to be volatile. it is only ever accessed in the ordered executor thread for this ledgerhandle. Rather than throwing synchronized around everything, we should start asserting in methods that we are in fact running in the ordered executor thread.
The previous blockAddCompletion stuff would not have been safe if these weren't in the same thread. [ Full content available at: https://github.com/apache/bookkeeper/pull/1646 ] This message was relayed via gitbox.apache.org for devnull@infra.apache.org