Since you are at this. There is another issue about the entry point. Right now there are duplicate `<script>` tags for the shared chunks. If you view page source, there will be multiple `vendors-addSlice-common-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js`
For example in the `head_js` ```html <script src="/static/assets/dist/vendors-addSlice-common-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js"></script> <script src="/static/assets/dist/vendors-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js"></script> <script src="/static/assets/dist/theme.0fe210d7.entry.js"></script> <script src="/static/assets/dist/vendors-addSlice-common-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js"></script> <script src="/static/assets/dist/vendors-addSlice-common-dashboard-explore-profile-sqllab-welcome.0fe210d7.chunk.js"></script> <script src="/static/assets/dist/addSlice-common-dashboard-explore-profile-sqllab-welcome.0fe210d7.chunk.js"></script> <script src="/static/assets/dist/common.0fe210d7.entry.js"></script> ``` Because each entry in the js manifest lists an array of chunks each entry point needs, independent of other entry points. When we render this directly to FAB template, it does not de-dup. XHR Performance-wise not too bad as browser only fetches and parses once, but for correctness, if the chunk executes something, it executes multiple time. [ Full content available at: https://github.com/apache/incubator-superset/pull/5880 ] This message was relayed via gitbox.apache.org for [email protected]
